Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curve analysis multi-canvas plotting #804

Conversation

nkanazawa1989
Copy link
Collaborator

Summary

There was missing data filtering in curve analysis plotting, which results in the broken output figure when multi canvas plotting is enabled. Currently this feature is only used by CR Hamtomo experiment.

Current: data filtering is missing and all series are plotted on every canvas
image

Fixed:
image

Details and comments

This doesn't affect the result of fitting. Just visualization issue.

@nkanazawa1989 nkanazawa1989 added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels May 9, 2022
Copy link
Collaborator

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since to an end user this only effects the CR Hamiltonian experiment, you should probably mention that you fixed the figures generated for that experiment in the release note.

@chriseclectic chriseclectic merged commit f547e6b into Qiskit-Extensions:main May 9, 2022
chriseclectic pushed a commit to chriseclectic/qiskit-experiments that referenced this pull request May 18, 2022
chriseclectic pushed a commit to chriseclectic/qiskit-experiments that referenced this pull request May 18, 2022
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
@nkanazawa1989 nkanazawa1989 deleted the fix/broken_multi_series_plot branch October 27, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants