Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform support description #844

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

wshanks
Copy link
Contributor

@wshanks wshanks commented Feb 19, 2024

  • Mention a few non-supported modes (FreeBSD, WebAssembly, PyPy) by name so they come up more easily for someone searching for them.
  • Fix typo (missing "be").
  • Downgrade confidence that Qiskit will work on other platforms
  • Expand reference to CPython

* Mention a few non-supported modes (FreeBSD, WebAssembly, PyPy) by name
  so they come up more easily for someone searching for them.
* Fix typo (missing "be").
* Downgrade confidence that Qiskit will work on other platforms
* Expand reference to CPython
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/start/install.mdx Outdated Show resolved Hide resolved
@wshanks
Copy link
Contributor Author

wshanks commented Feb 19, 2024

My main motivation here was to get "pypy" into the documentation so it would show up in a search. In Qiskit/qiskit#11822, I even linked to this page about operating system support to say that I only saw operating system support discussed when really it did mention only supporting CPython. I added FreeBSD and WebAssembly as what I thought would be the other "odd" cases that someone might actually wonder about.

I wondered if the section should be using "platform" instead of "operating system". It discusses both CPU architecture and operating system for the most part but also includes the mention of Python interpreter (and whatever WebAssembly is...I guess a "runtime"). That would be a larger change, so I didn't do that here.

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Feb 19, 2024
Merged via the queue into Qiskit:main with commit 3be11a8 Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants