Update submission form #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Jul 8, 2024
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
frankharkins
commented
Jul 11, 2024
tests/utils/test_utils.py
Outdated
Comment on lines
75
to
79
| if len(repo.description) > 135: | ||
| raise AssertionError( | ||
| f'Description for "{repo.name}" is too long!\n' | ||
| f"Rephrase to under 135 characters (currently {len(repo.description)} characters)" | ||
| ) |
There was a problem hiding this comment.
I didn't use self.assertLessEqual here so I could provide a more helpful error message.
Eric-Arellano
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the submission form with some of the feedback from design. We can't currently update the links as the new ones don't exist, and the "group" / "labels" attributes will need to stay until the current page is removed. Otherwise, all comments are addressed.