gphase expression cannot have gate modifiers applied
#88
Labels
Comments
|
Whoops. Just saw this now. Thanks. |
|
ha no worries - I only noticed and posted it a few minutes ago |
|
This is a pretty quick fix. But I'll look at it after I've finished chores for 1.0. |
jlapeyre
added a commit
that referenced
this issue
Feb 4, 2024
This commit adds support for gphase calls with gate modifiers. gpahse calls *without* modifiers are, as before, represented by `asg::Stmt::GPhaseCall`. gphase calls *with* modifiers are represented by `asg::Stmt::ModifiedGPhaseCall`. The latter has the same accessor `arg()` as `GPhaseCall`. But it adds `modifiers()`. Closes #88
jlapeyre
added a commit
that referenced
this issue
Feb 4, 2024
This commit adds support for gphase calls with gate modifiers. gpahse calls *without* modifiers are, as before, represented by `asg::Stmt::GPhaseCall`. gphase calls *with* modifiers are represented by `asg::Stmt::ModifiedGPhaseCall`. The latter has the same accessor `arg()` as `GPhaseCall`. But it adds `modifiers()`. Closes #88
jlapeyre
added a commit
that referenced
this issue
Feb 4, 2024
* Add GPhaseCallExpr * Replace GPhaseCallStmt with GPhaseCallExpr and ExprStmt * Add ModifiedGPhaseCall to ASG * Parse modified gphase to `asg::ModfiedGPhaseCall` This commit adds support for gphase calls with gate modifiers. gpahse calls *without* modifiers are, as before, represented by `asg::Stmt::GPhaseCall`. gphase calls *with* modifiers are represented by `asg::Stmt::ModifiedGPhaseCall`. The latter has the same accessor `arg()` as `GPhaseCall`. But it adds `modifiers()`. Closes #88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In trying to parse the
stdgates.incinclude at the moment, the parser emits syntactic errors on the linegate p(lambda) a { ctrl @ gphase(lambda) a; }because it doesn't like the
gphaseafter the modifier:As far as Qiskit is concerned this isn't super important, because we're just going to ignore whatever's going on in stdlib
gatestatements anyway, but it does mean we can't use the proper version of the file on our import path yet.The text was updated successfully, but these errors were encountered: