Support declaring single hardware qubits #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statements like `qubit $1;` are supported. This commit also undoes the previous commit (last commit before tagging 0.3.0) that improved the error handling for attemted declaration of hardware qubits. API CHANGE: new variant in asg::Stmt The variant is `Stmt::DeclareHardwareQubit(DeclareHardwareQubit)` The struct `DeclareHardwareQubit` has method `name` to retrieve an instance of `asg::HardwareQubit`. Note that `asg::HardwareQubit` is not new in this commit.
jlapeyre
force-pushed
the
more-declare-hw-qubit
branch
from
7320ccd
to
bf996af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statements like
qubit $1;are supported.This commit also undoes the previous commit (last commit before tagging 0.3.0) that improved the error handling for attemted declaration of hardware qubits.
API CHANGE: new variant in asg::Stmt
The variant is
Stmt::DeclareHardwareQubit(DeclareHardwareQubit)Declaring hardware qubits is not in the OQ3 spec. But all of our current users encounter (or write) qasm code with HW qubit declarations.
The struct
DeclareHardwareQubithas methodnameto retrieve an instance ofasg::HardwareQubit. Note thatasg::HardwareQubitis not new in this commit.