Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted the array elements in ast_src.rs #189

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

Raghav-Bell
Copy link
Contributor

It fixes #161

@Raghav-Bell
Copy link
Contributor Author

CI tests are failing locally for rustc 1.71.0 (8ede3aae2 2023-07-12) with clone on copy error
at the following thanks.

raw: self.raw.clone(),

@jlapeyre
Copy link
Collaborator

Thanks for the contribution!

I'm still not 100% happy with the state of the file. I'd like to review the categories.
But, this PR, alphabetizing within the categories, is definitely an improvement.

Regarding the CI, I have run into the same problem sometimes. I have found it difficult to make a single version of the source compile and lint cleanly under both 1.75 and 1.71. I tried to use some conditional compilation. I didn't solve the problem, although I don't recall the details.

@jlapeyre jlapeyre merged commit 5305ac3 into Qiskit:main Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize array elements in ast_src.rs
2 participants