Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality in symbols.rs #215

Merged
merged 3 commits into from
May 2, 2024
Merged

Improve code quality in symbols.rs #215

merged 3 commits into from
May 2, 2024

Commits on Apr 5, 2024

  1. Add docstrings and an assert

    @jlapeyre
    jlapeyre committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0b5a78d View commit details
    Browse the repository at this point in the history

  2. Add doc strings and comments

    @jlapeyre
    jlapeyre committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    28c102f View commit details
    Browse the repository at this point in the history

  3. Remove scope_level from SymbolRecord 

    This was unused. There was a comment about "awkward" scope numbering,
and indeed some kind of awkward numbering. I removed all of that as
well. We can probably figure it out again quickly if and when needed.
    @jlapeyre
    jlapeyre committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    483fd8e View commit details
    Browse the repository at this point in the history