Return &[T] rather than Vec<T> and similar in getters
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
approved these changes
Jan 22, 2024
|
I might as well add a commit to this PR changing the others as well. |
jlapeyre
force-pushed
the
barrier-getter
branch
from
43c843c
to
23f17fa
Compare
There are several return types in asg.rs that are improved. This causes a bit of a change in the API. So validate.rs is updated External users, that is the qiskit importer, will likely need to be updated.
jlapeyre
force-pushed
the
barrier-getter
branch
from
23f17fa
to
6920e11
Compare
jlapeyre
changed the title
&[T] rather than Vec<T> and similar in getters
|
This PR was approved. But the additional changes mentioned in #75 (review) were added in 6920e11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments at bottom of #71
Return
&[T]rather thanVec<T>and similarThere are several return types in asg.rs that are improved.
This causes a bit of a change in the API. So validate.rs is updated
External users, that is the qiskit importer, will likely need to
be updated.
This PR has been broadened in response to the immediately following comment.