This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
reviewed
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still draft, but thought I'd leave some comments as I've seen some of these errors before. Feel free to ignore
Thanks to @frankharkins! Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
…ware`. Thanks to @frankharkins for pointing that incredibly quickly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! My general feedback is the following:
- Focus more on circuits and expectation values in your "background" sections. These are necessary to understand your Runtime material. Rely on the UQuIC foundation more.
- Make code section interactive. Turn it into a guided activity. Have reader fill in code themselves. Small additions by reader are still very valuable. Make problem easier as needed
- Reduce formality. Rely on intuitive concepts ("expectation values are the average value of the observable when measuring..."). Use only a little set theory notation.
- Mathematical Rigor section is almost entirely unnecessary. Only one or two theorems needed. State the theorem in clear, perhaps informal language, followed by proof, so that reader can get theorem without seeing proof. I've suggested a simplified proof in one of comments.
vabarbosa
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding a few notes for us to keep in mind:
uses-hardware
tag to those cellsImplementation details
How to read this PR
https://platypus-pr-1965.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/course/algorithm-design
Screenshots