Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Variational Algorithm Design #1965

Merged
merged 121 commits into from
Apr 19, 2023
Merged

Variational Algorithm Design #1965

merged 121 commits into from
Apr 19, 2023

Conversation

pandasa123
Copy link
Contributor

@pandasa123 pandasa123 commented Mar 2, 2023

Changes

Adding a few notes for us to keep in mind:

  • LaTeX comments cause MathJAX issues
  • Cells that require service authentication will fail in the CI. Add the uses-hardware tag to those cells

Implementation details

How to read this PR

https://platypus-pr-1965.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/course/algorithm-design

Screenshots

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still draft, but thought I'd leave some comments as I've seen some of these errors before. Feel free to ignore

notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/instances.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/applications.ipynb Outdated Show resolved Hide resolved
Thanks to @frankharkins!

Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
…ware`. Thanks to @frankharkins for pointing that incredibly quickly
Copy link
Contributor

@jacobwatkins1 jacobwatkins1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! My general feedback is the following:

  • Focus more on circuits and expectation values in your "background" sections. These are necessary to understand your Runtime material. Rely on the UQuIC foundation more.
  • Make code section interactive. Turn it into a guided activity. Have reader fill in code themselves. Small additions by reader are still very valuable. Make problem easier as needed
  • Reduce formality. Rely on intuitive concepts ("expectation values are the average value of the observable when measuring..."). Use only a little set theory notation.
  • Mathematical Rigor section is almost entirely unnecessary. Only one or two theorems needed. State the theorem in clear, perhaps informal language, followed by proof, so that reader can get theorem without seeing proof. I've suggested a simplified proof in one of comments.

notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
notebooks/algorithm-design/concepts.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vabarbosa vabarbosa merged commit 844e3d7 into main Apr 19, 2023
@vabarbosa vabarbosa deleted the algorithm-design branch April 19, 2023 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants