Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Updated preview workflow with the new reusable workflow logic #244

Merged
merged 1 commit into from Jan 11, 2022

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jan 11, 2022

This PR will replace the old github action preview logic for the new reusable workflow that we are applying in qiskit.org. As reference we have the issue Qiskit/qiskit.org#2398

@Tansito
Copy link
Member Author

Tansito commented Jan 11, 2022

How in this case platypus seems to use the PORT 8080 we can just remove that variable to use the default value.

Copy link
Member

@abdonrd abdonrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

Copy link
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thank you.

@techtolentino techtolentino merged commit 47403e5 into main Jan 11, 2022
@techtolentino techtolentino deleted the reusable-preview-workflow branch January 11, 2022 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants