Allow NoiseModel.as_dict() to return a serializable dict #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional `serializable` keyword to `NoiseModel.as_dict()` that returns a dictionary containing types that can be serialized directly by stdlib's json.
chriseclectic
approved these changes
Apr 24, 2019
Closed
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
* Add optional serialization to NoiseModel.as_dict Add an additional `serializable` keyword to `NoiseModel.as_dict()` that returns a dictionary containing types that can be serialized directly by stdlib's json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional parameter to
NoiseModel.as_dict()for returning a "dict composed only of types that can be serialized directly usingjson.dumps()without the need for a custom encoder". It is mostly for the needs ofIBMQProvider- since online simulators can also accept noise models, it allows the serialization to be contained withinAerwithout requiring extra imports or duplication in the other provider.I went with an approach that hopefully minimizes the impact of this change - by default, the parameter is set to
Falsefor preserving current behaviour, and relies on the existing AerJSONEncoder` doing a dummy "dump -> load" cycle.Details and comments