Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documents and tutorials which supports Qiskit 1.0 and Primitives V2 #2160

Merged
merged 18 commits into from
Jun 14, 2024

Conversation

divshacker
Copy link
Contributor

@divshacker divshacker commented Jun 2, 2024

Summary

This PR Updates the documentation and tutorials according to new version of Qiskit and Primitives V2
fixes #2114 #2163

Details and comments

More Details can be found in the above linked issue

@divshacker divshacker marked this pull request as draft June 2, 2024 13:15
@divshacker
Copy link
Contributor Author

Hey, @doichanj
I have updated the code used in the tutorials, Resolved every error coming due to compatibility issue.
I will start updating the documentation now.
If there's any thing that needs to be updated right now, Just let me know.
Thanks

@doichanj doichanj self-requested a review June 4, 2024 02:10
@doichanj doichanj added this to the Aer 0.15.0 milestone Jun 4, 2024
@doichanj doichanj added the documentation Something is not clear or error in description label Jun 4, 2024
@divshacker divshacker marked this pull request as ready for review June 4, 2024 04:06
@@ -22,7 +22,7 @@
extras_requirements = {"dask": ["dask", "distributed"]}

requirements = [
"qiskit>=0.45.2",
"qiskit>=1.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for documentation?
If so, we have to discuss we can upgrade qiskit or not before merging.
(We are planning to upgrade in Aer 0.15 release but I think it is too early to upgrade to qiskit 1.1)

Copy link
Contributor Author

@divshacker divshacker Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Suggested by @kevinsung that's why I just updated.
Anyway I don't think there should be any problem, I have made all the tutorials compatible to qiskit 1.1
If you want I can revert that also.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I misunderstood the issue. I thought that the code updates in the tutorials would require Qiskit 1.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that we can merge setup.py with Qiskit 1.1 requirement

Copy link
Collaborator

@doichanj doichanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating tutorials

@doichanj doichanj merged commit 2d4e101 into Qiskit:main Jun 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something is not clear or error in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documents and tutorials
3 participants