Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #32: Documentation fixes in CONTRIBUTING and fix import in terra-integrated tests #33

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Issue #32: Documentation fixes in CONTRIBUTING and fix import in terra-integrated tests #33

merged 3 commits into from
Jan 22, 2019

Conversation

jlatone
Copy link
Contributor

@jlatone jlatone commented Jan 19, 2019

Summary

Fixed a couple documentation errors I encountered when building.

Details and comments

Fixed a bad dash character and added cmake flags for installing the terra-integrated tests.

@jlatone
Fixed hyphen in command (so lazy people like me can simply copy/paste…
bbbf12c 
… the command)

-—install => --install
@jlatone
Addition of mac platform flags for python ./setup.py install
a31d3c0 
if you had to use --plat-name macosx-10.9-x86_64 for bdist_wheel then you need to do this for install:
python ./setup.py install -- -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.9 -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64
@jlatone
#32 Fix import for state_fidelity for terra-integrated tests to run
80b1b26 
Fixed "from qiskit.quantum_info import state_fidelity"
@jlatone jlatone changed the title Documentation fixes in CONTRIBUTING Issue #32: Documentation fixes in CONTRIBUTING and fix import in terra-integrated tests Jan 19, 2019
atilag
atilag approved these changes Jan 22, 2019
View reviewed changes
.github/CONTRIBUTING.rst
@@ -257,6 +257,8 @@ and then run `unittest` Python framework.
.. code::

qiskit-aer$ python ./setup.py install
# if you had to use --plat-name macosx-10.9-x86_64 for bdist_wheel then you need to do this for install:
# python ./setup.py install -- -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.9 -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use --plat-name macosx-10.9-x86_64 here as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we can`t.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--plat-name is an option for the bdist_wheel subcommand and not others like install

@atilag atilag merged commit 97c6a61 into Qiskit:master Jan 22, 2019
@jlatone
Copy link
Contributor Author

jlatone commented Jan 31, 2019

@atilag have you ever seen the following json-related error when trying to build aer, more specifically, when Building CXX object CMakeFiles/qasm_simulator.dir/contrib/standalone/qasm_simulator.cpp.o:

/anaconda3/envs/QiskitDevenv/lib/python3.7/site-packages/cmake/data/CMake.app/Contents/bin/cmake -E __run_co_compile --tidy="/usr/local/bin/clang-tidy;-checks=*;-format-style=google;-header-filter=\"/Users/jlatone/Documents/qiskitdev/qiskit-aer/src\";-quiet" --source=../../../contrib/standalone/qasm_simulator.cpp -- /usr/bin/clang++   -I../../../src -I/usr/local/opt/libomp/include -isystem ../../../src/third-party/headers -stdlib=libc++ -ffast-math -pedantic -Wall -Wfloat-equal -Wundef -Wcast-align -Wwrite-strings -Wmissing-declarations -Wredundant-decls -Wshadow -Woverloaded-virtual -Xpreprocessor -fopenmp -O3 -DNDEBUG -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -mmacosx-version-min=10.9   -std=gnu++14 -MD -MT CMakeFiles/qasm_simulator.dir/contrib/standalone/qasm_simulator.cpp.o -MF CMakeFiles/qasm_simulator.dir/contrib/standalone/qasm_simulator.cpp.o.d -o CMakeFiles/qasm_simulator.dir/contrib/standalone/qasm_simulator.cpp.o -c ../../../contrib/standalone/qasm_simulator.cpp
../../../src/third-party/headers/nlohmann_json.hpp:1201:9: error: static_assert failed "could not find from_json() method in T's namespace" [clang-diagnostic-error]
        static_assert(sizeof(BasicJsonType) == 0,
        ^

@jlatone
Copy link
Contributor Author

jlatone commented Jan 31, 2019

I also haven't been able to figure out how to build & install aer using pip.
Doing a
pip install -e .
runs into the -std=libc++ issue, and the following didn't work either
pip install --install-option="--plat-name macosx-10.7-x86_64" -e .

I'll try other incantations...

@atilag atilag mentioned this pull request Feb 4, 2019
Closed
dcmckayibm pushed a commit to dcmckayibm/qiskit-aer that referenced this pull request Nov 3, 2019
@atilag
Merge pull request Qiskit#33 from jlatone/master
139b480 
Issue Qiskit#32: Documentation fixes in CONTRIBUTING and fix import in terra-integrated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atilag atilag atilag approved these changes

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlatone @atilag