Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy to tests #257

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Add mypy to tests #257

merged 1 commit into from
Mar 8, 2022

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 8, 2022

Summary

Fixes #255

Details and comments

@coveralls
Copy link

coveralls commented Mar 8, 2022

Pull Request Test Coverage Report for Build 1949135207

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.313%

Totals Coverage Status
Change from base Build 1943784874: 0.0%
Covered Lines: 1743
Relevant Lines: 4219

💛 - Coveralls

Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kt474

@daka1510 daka1510 merged commit 534d8dc into Qiskit:main Mar 8, 2022
@kt474 kt474 deleted the test-mypy branch October 25, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mypy does not check types in test code
3 participants