Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test_composite_job #264

Merged
merged 8 commits into from
Mar 31, 2022

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 17, 2022

Summary

Skipping two tests that are timing out

Details and comments

@coveralls
Copy link

coveralls commented Mar 17, 2022

Pull Request Test Coverage Report for Build 2016522053

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.2%) to 41.59%

Totals Coverage Status
Change from base Build 2015263740: 4.2%
Covered Lines: 1758
Relevant Lines: 4227

💛 - Coveralls

Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt474 Could you please resolve conflicts?

@kt474 kt474 changed the title [WIP] Enable test_composite_job Enable test_composite_job Mar 30, 2022
@daka1510
Copy link
Collaborator

@kt474 did all tests in the updated file pass locally? If so, you can go ahead and integrate it from my perspective. The failures in the CI run in your fork look unrelated

qiskit_ibm_provider.exceptions.IBMBackendApiError: 'Error submitting job: "HTTPSConnectionPool(host=\'api-qcon.quantum-computing.ibm.com\', port=443): Read timed out. (read timeout=None)"'

@daka1510 daka1510 self-requested a review March 30, 2022 10:14
@kt474
Copy link
Member Author

kt474 commented Mar 30, 2022

@kt474 did all tests in the updated file pass locally? If so, you can go ahead and integrate it from my perspective. The failures in the CI run in your fork look unrelated

qiskit_ibm_provider.exceptions.IBMBackendApiError: 'Error submitting job: "HTTPSConnectionPool(host=\'api-qcon.quantum-computing.ibm.com\', port=443): Read timed out. (read timeout=None)"'

Yeah all the tests pass locally

@daka1510
Copy link
Collaborator

Thanks for the confirmation, @kt474. Then it looks good from my side.

Tried to merge but it's blocked by @rathishcholarajan rejected review.

@daka1510
Copy link
Collaborator

@rathishcholarajan up to you to merge now :)

@rathishcholarajan rathishcholarajan merged commit cb8bce0 into Qiskit:main Mar 31, 2022
@kt474 kt474 deleted the enable-test-composite-job branch October 25, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants