Add support for BackendV2 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathishcholarajan
added
the
Changelog: API Change
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
rathishcholarajan
force-pushed
the
backendv2
branch
from
9b9db11
to
541e49f
Compare
daka1510
reviewed
Apr 6, 2022
Pull Request Test Coverage Report for Build 2106543868Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Let's not merge this until we get an all pass on integration tests in my fork. |
daka1510
reviewed
Apr 7, 2022
…mprovements when lazy loading backends for a provider
… if need be now that we have a sub class Also convert us to s for t1 and t2 and ghz to hz for frequency and anharmonicity
mtreinish
reviewed
Apr 21, 2022
Comment on lines
+138
to
+155
| qubit_props = {} | ||
| for qubit, _ in enumerate(properties.qubits): | ||
| t_1 = properties.t1(qubit) * 1e-6 # microseconds to seconds | ||
| t_2 = properties.t2(qubit) * 1e-6 # microseconds to seconds | ||
| frequency = properties.frequency(qubit) * 1e9 # GHz to Hz | ||
| try: | ||
| anharmonicity = ( | ||
| properties.qubit_property(qubit, "anharmonicity")[0] * 1e9 | ||
| ) # GHz to Hz | ||
| except Exception: # pylint: disable=broad-except | ||
| anharmonicity = None | ||
| qubit_props[qubit] = IBMQubitProperties( # type: ignore[no-untyped-call] | ||
| t1=t_1, | ||
| t2=t_2, | ||
| frequency=frequency, | ||
| anharmonicity=anharmonicity, | ||
| ) | ||
| return qubit_props |
There was a problem hiding this comment.
This should be changed to a list return instead of a dict with int keys.
There was a problem hiding this comment.
Oops sorry didn't notice these comments, sure will open a new PR with these changes.
| "reset": Reset(), | ||
| } | ||
| custom_gates = {} | ||
| target = Target(num_qubits=configuration.n_qubits) |
There was a problem hiding this comment.
We should call qubit_props_dict_from_props once it returns a list and set qubit_properties=qubit_properties here from that list return.
Comment on lines
+348
to
+370
| def qubit_properties( | ||
| self, qubit: Union[int, List[int]] | ||
| ) -> Union[IBMQubitProperties, List[IBMQubitProperties]]: | ||
| """Return IBMQubitProperties for a given qubit. | ||
|
|
||
| Args: | ||
| qubit: The qubit to get the | ||
| :class:`~qiskit_ibm_provider.IBMQubitProperties` object for. This can | ||
| be a single integer for 1 qubit or a list of qubits and a list | ||
| of :class:`~qiskit_ibm_provider.IBMQubitProperties` objects will be | ||
| returned in the same order | ||
|
|
||
| Returns: | ||
| IBMQubitProperties or a list of IBMQubitProperties | ||
| """ | ||
| self._get_properties() | ||
| if not self._qubit_properties: | ||
| self._qubit_properties = qubit_props_dict_from_props(self._properties) | ||
| if isinstance(qubit, int): # type: ignore[unreachable] | ||
| return self._qubit_properties.get(qubit) | ||
| if isinstance(qubit, List): | ||
| return [self._qubit_properties.get(q) for q in qubit] | ||
| return None |
There was a problem hiding this comment.
If we set this in the target this can be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for BackendV2
Details and comments
Copied from Qiskit/qiskit-ibmq-provider#1108
Fixes #238