Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing integration tests #320

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

rathishcholarajan
Copy link
Member

@rathishcholarajan rathishcholarajan commented Apr 8, 2022

Summary

Some tests were run using 1 public and 1 private provider in qiskit-ibmq-provider. Replicating that behavior here using QISKIT_IBM_INSTANCE_PRIVATE env variable, instead of running tests against all 6 or 7 providers attached to the test account, which was causing integration tests forever to complete and timeout eventually after 6 hours (https://github.com/Qiskit/qiskit-ibm-provider/actions/runs/2106829307).

Details and comments

I have added QISKIT_IBM_INSTANCE_PRIVATE env variable for both staging and production environments.

@coveralls
Copy link

coveralls commented Apr 8, 2022

Pull Request Test Coverage Report for Build 2114641158

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.973%

Totals Coverage Status
Change from base Build 2112852255: 0.0%
Covered Lines: 1802
Relevant Lines: 5465

💛 - Coveralls

Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rathishcholarajan rathishcholarajan merged commit 8dc2ad1 into Qiskit:main Apr 8, 2022
@rathishcholarajan rathishcholarajan deleted the fix-failing-tests branch April 8, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants