Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job.delete() #330

Closed
wants to merge 13 commits into from
Closed

Add job.delete() #330

wants to merge 13 commits into from

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Apr 21, 2022

Summary

cherry picking old pr from #20

Details and comments

@kt474 kt474 changed the title Add job.delete() [WIP] Add job.delete() Apr 21, 2022
@coveralls
Copy link

coveralls commented Apr 21, 2022

Pull Request Test Coverage Report for Build 2228563188

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 17 (41.18%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 35.903%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/api/clients/account.py 1 2 50.0%
qiskit_ibm_provider/api/rest/job.py 1 2 50.0%
qiskit_ibm_provider/job/utils.py 1 2 50.0%
qiskit_ibm_provider/job/ibm_job.py 4 11 36.36%
Totals Coverage Status
Change from base Build 2222686601: 0.007%
Covered Lines: 1849
Relevant Lines: 5150

💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review April 22, 2022 20:21
@kt474 kt474 changed the title [WIP] Add job.delete() Add job.delete() Apr 22, 2022
@kt474
Copy link
Member Author

kt474 commented Apr 25, 2022

Do we also want to add a delete method to the backend service or is that redundant?

provider.backend.delete_job(job.job_id())

@rathishcholarajan rathishcholarajan added the on hold Cannot fix yet label May 2, 2022
@rathishcholarajan
Copy link
Member

This PR will conflict with the proposed changes here - https://github.com/Qiskit/qiskit-ibm-provider/pull/338/files#diff-564502a32b289a9dba68e4385287a02dd7e28f86a7f2f9de8603af5408a82dcbR549
So I would like to wait for the other PR to merge before updating and merging this.

@kt474
Copy link
Member Author

kt474 commented Nov 7, 2022

stale, closing for now

@kt474 kt474 closed this Nov 7, 2022
@kt474 kt474 deleted the add-job-delete branch June 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Cannot fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants