-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Pad idle qubits at your own risk #737
Closed
taalexander
wants to merge
11
commits into
Qiskit:main
from
taalexander:pad-idle-qubits-at-your-own-risk
Closed
Clean up Pad idle qubits at your own risk #737
taalexander
wants to merge
11
commits into
Qiskit:main
from
taalexander:pad-idle-qubits-at-your-own-risk
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new flag to the scheduling padding passes, schedule_idle_qubits, which is used to opt-in to scheduling idle qubits. By default these passes will only schedule qubits which are active. This is a change in behavior from before where the previous default is all qubits were scheduled. This was undesireable because it's adding uneceesary instructions to the job payload which will need to be processed which are effectively a no-op. The only real use case for adding delays to idle wires is visualization, so it's left as an option to re-enable the previous default. Fixes Qiskit#723 Co-authored-by: Thomas Alexander <thomas.a.alexander@ibm.com>
Pad non-idle qubits in control flow blocks
Pull Request Test Coverage Report for Build 6268382298
💛 - Coveralls |
Hi @taalexander , please let me and @kt474 know what you'd like to do with this PR. It's been open for a few months and has accumulated some conflicts. Do you still want this to be reviewed? If so, please provide details about the changes. |
Closing for now, feel free to reopen if still necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments