Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Pad idle qubits at your own risk #737

Closed

Conversation

taalexander
Copy link
Contributor

Summary

Details and comments

mtreinish and others added 11 commits September 12, 2023 15:24
This commit adds a new flag to the scheduling padding passes,
schedule_idle_qubits, which is used to opt-in to scheduling idle qubits.
By default these passes will only schedule qubits which are active. This
is a change in behavior from before where the previous default is all
qubits were scheduled. This was undesireable because it's adding
uneceesary instructions to the job payload which will need to be
processed which are effectively a no-op. The only real use case for
adding delays to idle wires is visualization, so it's left as an option
to re-enable the previous default.

Fixes Qiskit#723

Co-authored-by: Thomas Alexander <thomas.a.alexander@ibm.com>
Pad non-idle qubits in control flow blocks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6268382298

  • 23 of 24 (95.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 51.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/transpiler/passes/scheduling/block_base_padder.py 20 21 95.24%
Totals Coverage Status
Change from base Build 6249445443: 0.1%
Covered Lines: 3354
Relevant Lines: 6551

💛 - Coveralls

@drew-distefano
Copy link
Collaborator

Hi @taalexander , please let me and @kt474 know what you'd like to do with this PR. It's been open for a few months and has accumulated some conflicts. Do you still want this to be reviewed? If so, please provide details about the changes.

@kt474
Copy link
Member

kt474 commented Apr 16, 2024

Closing for now, feel free to reopen if still necessary

@kt474 kt474 closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants