This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Bump pin to unify lint job versions across elements #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to unify the versions of pylint run across all the elements this commit bumps the pinned versions of pylint and astroid to be the latest and what we are syncing all the elements to use. This should make working between all the elements easier to do. Related To: Qiskit/qiskit#3629
In a typical example of why we hard pin to a single version for everything related to pylint in CI the change from 2.4.2 to 2.4.4 introduced a new rule (or changed rule behavior) that caused failures. This commit fixes those by skipping because the rule doesn't apply to those files.
chriseclectic
approved these changes
Jan 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In an effort to unify the versions of pylint run across all the elements
this commit bumps the pinned versions of pylint and astroid to be the
latest and what we are syncing all the elements to use. This should make
working between all the elements easier to do.
Details and comments
Related To: Qiskit/qiskit#3629