Remove tools/apps #1184
Merged
Remove tools/apps #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaygambetta
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
mtreinish,
nonhermitian and
taalexander
as code owners
|
@antoniomezzacapo and @chunfuchen can you look at this. |
chunfuchen
approved these changes
Nov 1, 2018
ajavadia
approved these changes
Nov 1, 2018
|
@chunfuchen there are some tests here that I think would be useful to have in Aqua. Can you please see if that's the case? |
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 9, 2019
The infrastructure in terra needed to run vqe was removed in Qiskit#1184 in favor of just using aqua. However the performance test that depending on this to benchmark running vqe was not removed at the same time. This commit corrects the oversight and just removes the test since it doesn't work anymore. We should just rely on aqua to run vqe (and aqua to do the benchmarking).
jaygambetta
pushed a commit
that referenced
this pull request
Jan 10, 2019
* Remove vqe performance test The infrastructure in terra needed to run vqe was removed in #1184 in favor of just using aqua. However the performance test that depending on this to benchmark running vqe was not removed at the same time. This commit corrects the oversight and just removes the test since it doesn't work anymore. We should just rely on aqua to run vqe (and aqua to do the benchmarking). * Remove H2 and LiH files too
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Removing apps * Removing test * Changlog
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Remove vqe performance test The infrastructure in terra needed to run vqe was removed in Qiskit#1184 in favor of just using aqua. However the performance test that depending on this to benchmark running vqe was not removed at the same time. This commit corrects the oversight and just removes the test since it doesn't work anymore. We should just rely on aqua to run vqe (and aqua to do the benchmarking). * Remove H2 and LiH files too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604
Now the aqua is out this is not needed.