Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_pass_manager_simulation in favor of level 1 default #2676

Merged
merged 9 commits into from
Jul 16, 2019

Conversation

ajavadia
Copy link
Member

@ajavadia ajavadia commented Jun 23, 2019

Summary

Follow up to #2672

@ajavadia ajavadia changed the title Remove preset_pass_manager_simulation in favor of level 1 default [WIP] Remove preset_pass_manager_simulation in favor of level 1 default Jun 23, 2019
@ajavadia ajavadia changed the title [WIP] Remove preset_pass_manager_simulation in favor of level 1 default [WIP] Remove default_pass_manager_simulation in favor of level 1 default Jun 24, 2019
@ajavadia ajavadia force-pushed the remove-preset-pm-simulation branch from c61b816 to 0c3a871 Compare June 28, 2019 21:22
@ajavadia ajavadia force-pushed the remove-preset-pm-simulation branch from 0c3a871 to 31185d1 Compare June 28, 2019 21:48
@ajavadia ajavadia changed the title [WIP] Remove default_pass_manager_simulation in favor of level 1 default Remove default_pass_manager_simulation in favor of level 1 default Jun 28, 2019
@ajavadia
Copy link
Member Author

This is out of WIP

1ucian0
1ucian0 previously approved these changes Jul 13, 2019
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to remove the change in test/python/basicaer/test_unitary_simulator.py in df45973, since it seems unrelated to this PR:
However, it's not passing, so I reverted it in 3a9084b. It probably needs adjustment. Is there any way to adjust this test minimally?

@ajavadia
Copy link
Member Author

I tried to remove the change in test/python/basicaer/test_unitary_simulator.py in df45973, since it seems unrelated to this PR:
However, it's not passing, so I reverted it in 3a9084b. It probably needs adjustment. Is there any way to adjust this test minimally?

No this change is needed because the global phase must be ignored in the comparison of unitaries.

@1ucian0 1ucian0 merged commit d067be3 into Qiskit:master Jul 16, 2019
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
…iskit#2676)

* remove default_pass_manager_sim in favor of default level 1

* Irrelevant change

* This change seems unrelated

* Revert "This change seems unrelated"

This reverts commit df45973.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants