fix measure sampling bug in BasicAer #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
lcapelluto,
mtreinish,
nonhermitian and
taalexander
as code owners
chriseclectic
force-pushed
the
fix-basicaer-sampler
branch
from
44e59f8
to
60ddec8
Compare
ajavadia
previously approved these changes
Jul 15, 2019
ajavadia
approved these changes
Jul 15, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* fix measure sampling bug in BasicAer * update changelog * linter * linting * add additional code comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2744. Adds some additional tests for BasicAer qasm simulator
Details and comments
Measure sampling was behaving incorrectly if a subset of qubits were measured since it was assuming the position in the measured qubit list was the qubit number.