Fix Schedule Plot reflecting duration of final schedule even if it is not plotted #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… duration for channels included in channels_to_plot parameter
Matt-Stypulkoski
requested review from
1ucian0,
ajavadia,
mtreinish and
nonhermitian
as code owners
taalexander
requested changes
Nov 7, 2019
There was a problem hiding this comment.
The idea of fix looks good to me.
Do you know why the starting and ending samples of the pulse aren't zero? I see this is the current behaviour on master too. @nkanazawa1989?
edit: created issue #3427 for the above.
…Matt-Stypulkoski/qiskit-terra into 3379-schedule-plot-not-updating
taalexander
approved these changes
Nov 7, 2019
1ucian0
added
the
Changelog: Bugfix
1ucian0
approved these changes
Nov 8, 2019
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
… not plotted (Qiskit#3418) * In draw function, have x-coordinate max be set by the longest channel duration for channels included in channels_to_plot parameter * Restructure logic for setting up plot range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3379. The matplotlib figure created from the draw function now has the x-axis max reflect the longest duration of the channels included in
channels_to_plot.Details and comments
The following code (taken from the original issue) would produce the output image below: