Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict hello_quantum ibmq example script to backends with at least two qubits #4511

Merged
merged 3 commits into from May 28, 2020

Conversation

romilly
Copy link
Contributor

@romilly romilly commented May 28, 2020

Summary

The hello_quantum example was repeatedly failing because it usually selected the 1-qubit Armonk provider, but it needs two qubits to run.

Details and comments

I've added a filter to ensure that only usable providers are selected.

There are no automated tests for this example, but it now runs on my machine. (I know, I know...)

Fixes #4510

@romilly romilly requested a review from a team as a code owner May 28, 2020 14:31
@CLAassistant
Copy link

CLAassistant commented May 28, 2020

CLA assistant check
All committers have signed the CLA.

@mtreinish mtreinish changed the title example now selects providers that offer at least two qubits Restrict hello_quantum ibmq example script to backends with at least two qubits May 28, 2020
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating this. There's no need to worry about the lack of tests, the unittest environment doesn't have access to real backends anyway so there isn't a good way to test this.

@mergify mergify bot merged commit 9e51e52 into Qiskit:master May 28, 2020
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
…this example. (Armonk does not!) (Qiskit#4511)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hello_quantum.py example fails because Armonk is a 1-qubit provider
3 participants