Return fast from transpile with empty input #7288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
the
Changelog: Bugfix
Pull Request Test Coverage Report for Build 1478066876
💛 - Coveralls |
mtreinish
reviewed
Nov 18, 2021
| @@ -240,6 +240,9 @@ def callback_func(**kwargs): | |||
| arg_circuits_list = isinstance(circuits, list) | |||
| circuits = circuits if arg_circuits_list else [circuits] | |||
|
|
|||
| if not circuits: | |||
There was a problem hiding this comment.
Are you concerned at all about the side effects of transpile(0), transpile(False)ortranspile(None)` here? I only ask because if a user did any of those I'd expect an error.
There was a problem hiding this comment.
Right before these lines, circuits is promoted to a 1-element list if it isn't one already, so in those cases, it'd all be promoted to circuits = [0], circuits = [False], etc. I didn't check to see if super invalid output fails somewhere else, but the boolean coercion shouldn't cause any more problems here.
There was a problem hiding this comment.
Ok cool I see that now on L241. Heh I should have looked at more than just strict diff to see the surrounding context.
mtreinish
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously
transpile([])raised a warning. Now we just return quickly without further tests, similarly to how we return early if we're asked to transpile a list ofSchedules.Details and comments
Fix #7287.