-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove version footers at tutorials #135
Comments
Replace
|
@diego-plan9 could you look at @rraymondhp suggestion for making a better version.ipnb |
@diego-plan9 I am proposing to replace the |
Otherwise, we have to make sure the contents of the |
@diego-plan9 Let us discuss how to check the version of python, qiskit, IBMQuantumExperience and other required packages here. Because the tutorial uses Therefore, for version checking we should think of other way than listing the contents of the |
I think the core question is what should the footer version contain. The original idea was that it would be a "single, static source of truth when it comes to the versions needed to run the tutorials", listing them based on the requirements of With your proposed implementation, the footer would contain information fetched from "the user's environment", or at least "from the specific user that submitted the PR for a specific tutorial". If that is the intent (for example, having someone with a trusted setup always recreate that information), it's fine, but I think it has the potential for leading to more confusion: for example, if a user with the wrong qiskit version happens to re-run For context, the |
But the The fix is to make sure that |
Yes - it would need to be updated and some measures taken to ensure they don't fall out of sync again, absolutely. But I think this is an organizational issue separate from the implementation: those measures will be needed with either approach, as long as some kind of "list of reference versions" are needed (in the other implementation, ensuring that it is recreated by a user with the right versions installed - it is doable, but I'm worried about fetching the information from the environment will end up being more error prone). This said - I actually wonder if the version footer does really serve a purpose now that the tutorials are going to have a more streamlined installation, with a single branch and targeting a single version? Except for |
Following up after some private conversations - it seems just removing the version footer (and instead adding a mention of just the |
Thanks Diego! |
@rraymondhp can you do this week and close this issue. |
I've addressed this in Pull Request #189 and have asked @rraymondhp to review. |
@jaygambetta I will finish this within this week. |
Version formatting edits addressing Issue #135
Description
The old release of qiskit-sdk-py is not compatible with the latest API.
Your Environment
The text was updated successfully, but these errors were encountered: