Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Remove Variational Algorithm Design course #3427

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Remove Variational Algorithm Design course #3427

merged 2 commits into from
Jul 17, 2023

Conversation

y4izus
Copy link
Contributor

@y4izus y4izus commented Jul 17, 2023 •
edited
Loading

Changes

Fix #3409

Implementation details

  • Deletes Variational Algorithm Design description page
  • Deletes the images and variables that are only used on that page
  • Changes the text on the CTA to let the user knows that the course is on the new learning platform
  • Changes the URL to have the CTA as an external link. (Final link will be addressed once the new learning platform goes live)

How to read this PR

  1. Go to the learn page on the preview
  2. Scroll to the courses section
  3. See that the Variational Algorithm Design course have the new CTA (text and icon)
  4. If you click on the CTAs you will go to the production page because the redirect is not created yet (waiting for launch)
  5. Check that the assets/variables that were only used on those pages are deleted to.

Screenshots

Captura de pantalla 2023-07-17 a las 15 05 48

@y4izus y4izus linked an issue Jul 17, 2023 that may be closed by this pull request
Remove course "Variational Algorithm Design" #3409
Closed
5 tasks
@paaragon paaragon self-requested a review July 17, 2023 13:23
techtolentino
techtolentino approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@techtolentino techtolentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @y4izus - your PR seems to cover everything I was looking for, related to the course page.

Nicely done

@y4izus y4izus merged commit 8fb22bb into feat/sunset-learn-01 Jul 17, 2023
6 checks passed
@y4izus y4izus deleted the yg-remove-variational-algo-design-course branch July 17, 2023 13:55
@eddybrando eddybrando mentioned this pull request Oct 16, 2023
Closed
4 tasks
eddybrando pushed a commit that referenced this pull request Oct 16, 2023
@y4izus @eddybrando
feat: remove "Variational Algorithm Design" course (#3427)
7092c8f 
* Deletes VAD page and assets

* Updates CTA
eddybrando added a commit that referenced this pull request Oct 18, 2023
@y4izus @aitanaviudes @eddybrando
feat: sunset learning pages (#3423)
a6ba82a 
* feat: remove "Variational Algorithm Design" course (#3427)

* Deletes VAD page and assets

* Updates CTA

* feat: remove "UQIC" course (#3426)

* Delete Basics of quantum information page and images

* Deletes Fundamentals of quantum algorithms page and images

* Deletes unnecesary links

* Changes CTA text

* Open courses as external links

* banners content updated (#3561)

* banners content updated

* fixed lint error

* updated incorrect date on paragraph

* updated mistakes on content

* feat: update banners content (#3563)

* links in banners updated

* deleted unnecessary comment

* fix: simplify styles

---------

Co-authored-by: ai7ana <124618211+aitanaviudes@users.noreply.github.com>
Co-authored-by: Eddybrando Vásquez <eddybrando.vasquez@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techtolentino techtolentino techtolentino approved these changes

@paaragon paaragon paaragon approved these changes

@eddybrando eddybrando Awaiting requested review from eddybrando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove course "Variational Algorithm Design"
3 participants
@y4izus @techtolentino @paaragon