This repository has been archived by the owner on May 17, 2024. It is now read-only.
feat(home): 1XP banner #3495
Merged
feat(home): 1XP banner #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techtolentino
previously approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Approving this - nice work here @eddybrando
(acknowledging that we're holding off on merge)
techtolentino
dismissed
their stale review
taking back the approval since this should PR into the feat/sunset-learn-01 branch
This was referenced Oct 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃毃 Important: Do not merge yet! Only merge when scheduled and after replacing the links.
Changes
This PR adds the 1XP banners and announcement sections to the Home page, the Learn page and the Learn Course pages.
Closes #3494
Implementation details
New components were create in the /components/OneXP folder. Note that it cannot be called "1XP.vue" since component names cannot start with numbers:
A new style was added to the UiCta component: "one-xp".
Screenshots
Large screen
Banner (Home)
Banner (Learn)
Banner (Learn Course)
Page Section (Home)
Page Section (Learn)
Medium screen
Banner (Home)
Banner (Learn)
Banner (Learn Course)
Page Section (Home)
Page Section (Learn)
Small screen
Banner (Home)
Banner (Learn)
Banner (Learn Course)
Page Section (Home)
Page Section (Learn)