Skip to content

Commit

Permalink
Add build requirements to requirements-dev.txt (#12190)
Browse files Browse the repository at this point in the history
We previously have not added the build-only requirements `setuptools`
and `setuptools-rust` to `requirements-dev.txt` because the majority of
contributors would not to build the Rust components outside of the
regular build isolation provided by `pip` or other PEP-517 compatible
builders.

Since we are accelerating our use of Rust, and it's more likely that
more users will need to touch the Rust components, this adds the build
requirements to the developer environment, so it's easier for people to
do our recommended

        python setup.py build_rust --inplace --release

for the cases that they want to test against optimised versions of the
Rust extensions while still maintaining a Python editable installation.
  • Loading branch information
jakelishman committed Apr 18, 2024
1 parent 9ede1b6 commit 437837e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
# never become actual package requirements, but still try to be as relaxed as
# possible so it's easy to develop multiple packages from the same venv.

# Build Rust directly
setuptools
setuptools-rust

# Style
black[jupyter]~=24.1

Expand Down
1 change: 0 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ passenv =
QISKIT_IN_PARALLEL
QISKIT_DOCS_GITHUB_BRANCH_NAME
deps =
setuptools_rust # This is work around for the bug of tox 3 (see #8606 for more details.)
-r{toxinidir}/requirements.txt
-r{toxinidir}/requirements-dev.txt
commands =
Expand Down

0 comments on commit 437837e

Please sign in to comment.