Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] get rid of float in favor of sympy #158

Closed
1ucian0 opened this issue Nov 22, 2017 · 5 comments
Closed

[WIP] get rid of float in favor of sympy #158

1ucian0 opened this issue Nov 22, 2017 · 5 comments
Assignees

Comments

@1ucian0
Copy link
Member

1ucian0 commented Nov 22, 2017

Float is a source of imprecision, as #111 shows. I'm working on a pull request to get rid of float (and math) in favor of sympy, as suggested to @awcross1.

Please, comment on this issue if you have any thought.

@1ucian0 1ucian0 changed the title get rid of float in favor to sympy get rid of float in favor of sympy Nov 22, 2017
@1ucian0 1ucian0 changed the title get rid of float in favor of sympy [WIP] get rid of float in favor of sympy Dec 5, 2017
@1ucian0 1ucian0 mentioned this issue Dec 7, 2017
@1ucian0 1ucian0 self-assigned this Dec 7, 2017
@nonhermitian
Copy link
Contributor

Why not just check if the value is one to floating point precision, and then just set to one if so? Adding an entire dependency for a single corner-case is probably not the way to go.

@1ucian0
Copy link
Member Author

1ucian0 commented Dec 14, 2017

Hi @nonhermitian ,
There are several situations where dealing with floats is hard. There are several zero checks and simplifications that we can delegate to this library.

@atilag
Copy link
Member

atilag commented Feb 8, 2018

@lbello what's the status of this issue? I know there have been several commits regarding float to sympy migration.

@1ucian0
Copy link
Member Author

1ucian0 commented Feb 21, 2018

For sure, the tools are still using floats. I will take a look to the rest. If it's just the tools, I would probably consider this done for now.

@diego-plan9 diego-plan9 removed their assignment Feb 21, 2018
@ewinston ewinston closed this as completed Mar 8, 2018
@1ucian0
Copy link
Member Author

1ucian0 commented Mar 8, 2018

The coming approach is to handle sympy and numpy options. Give option to the user to have a symbolic representation or an efficient numpy as numbers. Soon, a PR about this.

taalexander pushed a commit to taalexander/qiskit-terra that referenced this issue May 2, 2019
* add development strategy section

* fix ToC after adding dev strategy section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants