New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] get rid of float in favor of sympy #158
Comments
Why not just check if the value is one to floating point precision, and then just set to one if so? Adding an entire dependency for a single corner-case is probably not the way to go. |
Hi @nonhermitian , |
@lbello what's the status of this issue? I know there have been several commits regarding float to sympy migration. |
For sure, the tools are still using floats. I will take a look to the rest. If it's just the tools, I would probably consider this done for now. |
The coming approach is to handle sympy and numpy options. Give option to the user to have a symbolic representation or an efficient numpy as numbers. Soon, a PR about this. |
* add development strategy section * fix ToC after adding dev strategy section
Float is a source of imprecision, as #111 shows. I'm working on a pull request to get rid of float (and math) in favor of sympy, as suggested to @awcross1.
Please, comment on this issue if you have any thought.
The text was updated successfully, but these errors were encountered: