Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated logic from algorithms whose time has come #9866

Closed
woodsp-ibm opened this issue Mar 28, 2023 · 1 comment
Closed

Remove deprecated logic from algorithms whose time has come #9866

woodsp-ibm opened this issue Mar 28, 2023 · 1 comment
Labels
mod: algorithms Related to the Algorithms module

Comments

@woodsp-ibm
Copy link
Member

And in some cases long past (I noticed while reviewing the decorators change to the latest in #9864)

  • optimizers/adam_amsgrad.py (since 0.19.0)
  • optimizers/spsa (since 0.21.0)
  • phase_estimators/phase_estimation_result (since 0.18.0)
@woodsp-ibm woodsp-ibm added the mod: algorithms Related to the Algorithms module label Mar 28, 2023
@woodsp-ibm woodsp-ibm added this to the 0.24.0 milestone Mar 28, 2023
@woodsp-ibm woodsp-ibm mentioned this issue Mar 28, 2023
Merged
@mtreinish mtreinish modified the milestones: 0.24.0, 0.25.0 Apr 11, 2023
@mtreinish mtreinish removed this from the 0.25.0 milestone Jul 19, 2023
@ElePT ElePT mentioned this issue Jul 21, 2023
Closed
@woodsp-ibm
Copy link
Member Author

With the algorithms transferred over to qiskit-algorithms this old deprecated logic was removed there ahead of qiskit-algorithm's first release. As all the code here in Qiskit in qiskit.algorithms is deprecated, with users being instructed to upgrade/move to/install/use qiskit-algorithms, I am just going to close this off here as removing a couple of minor prior deprecated bits of code when the whole is now deprecated seems like an exercise in busy work with no real net value.

@woodsp-ibm woodsp-ibm closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
@woodsp-ibm woodsp-ibm mentioned this issue Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mod: algorithms Related to the Algorithms module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtreinish @woodsp-ibm