Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.25.1 release #10644

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Prepare 0.25.1 release #10644

merged 3 commits into from
Aug 17, 2023

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Aug 16, 2023

Summary

This commit prepares the 0.25.1 release, this consists of bumping the version number to 0.25.` in all the appropriate files. It also adds a prelude release note to provide a brief introduction to the release. When this commit merges it should be tagged as the 0.25.1 release. Of particular note for this release, this is the first time we'll be releasing the qiskit package from the qiskit-terra repo and also the first time we're publishing the documentation from this repo too.

Details and comments

  • Wait for last milestone PRs to merge
  • Add prelude release note
  • Update release notes

@mtreinish mtreinish added on hold Can not fix yet Changelog: None Do not include in changelog labels Aug 16, 2023
@mtreinish mtreinish added this to the 0.25.1 milestone Aug 16, 2023
@mtreinish mtreinish requested a review from a team as a code owner August 16, 2023 11:42
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

This commit prepares the 0.25.1 release, this consists of bumping the
version number to 0.25.` in all the appropriate files. It also adds a
prelude release note to provide a brief introduction to the release.
When this commit merges it should be tagged as the 0.25.1 release.
Of particular note for this release, this is the first time we'll be
releasing the qiskit package from the qiskit-terra repo and also the
first time we're publishing the documentation from this repo too.
@mtreinish mtreinish removed the on hold Can not fix yet label Aug 17, 2023
@mtreinish
Copy link
Member Author

mtreinish commented Aug 17, 2023

This should be ready to go now after #10659 merges (I already inlined the release notes).

Eric-Arellano
Eric-Arellano previously approved these changes Aug 17, 2023
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kevinhartman
kevinhartman previously approved these changes Aug 17, 2023
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This commit fixes an issue in the job definition for the new docs
deployment job added in Qiskit#10610. The new jobs are conditioned to only
execute from the Qiskit/qiskit-terra repo. However that line is being
flagged as a syntax error in github. This seems to be due to the double
quotes used for `"Qiskit"`. A similar condition exists on the
pre-existing github actions jobs but they use a single quote instead of
a double and they function correctly. This commit updates the condition
to used single quotes to match the working syntax in other jobs.

(cherry picked from commit d25f905)
@mtreinish
Copy link
Member Author

I had to bump this because I realized we forgot to backport #10635 which would have caused an error on tag. I just added that commit to this PR (since it's just a single line change).

@mtreinish mtreinish added this pull request to the merge queue Aug 17, 2023
@mtreinish mtreinish removed this pull request from the merge queue due to a manual request Aug 17, 2023
@mtreinish mtreinish merged commit 39b0cb8 into Qiskit:stable/0.25 Aug 17, 2023
13 checks passed
@mtreinish mtreinish deleted the prepare-0.25.1 branch August 17, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants