Add definition of Store instruction
#10946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
jakelishman
force-pushed
the
var/store-instruction
branch
from
c619ef9
to
850fe3e
Compare
Pull Request Test Coverage Report for Build 6989295039
💛 - Coveralls |
jakelishman
force-pushed
the
var/store-instruction
branch
from
850fe3e
to
3d2f8dd
Compare
This does not yet add the implementation of `QuantumCircuit.store`, which will come later as part of expanding the full API of `QuantumCircuit` to be able to support these runtime variables. The `is_lvalue` helper is added generally to the `classical.expr` module because it's generally useful, while `types.cast_kind` is moved from being a private method in `expr` to a public-API function so `Store` can use it. These now come with associated unit tests.
jakelishman
force-pushed
the
var/store-instruction
branch
from
3d2f8dd
to
bcc0546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This does not yet add the implementation of
QuantumCircuit.store, which will come later as part of expanding the full API ofQuantumCircuitto be able to support these runtime variables.The
is_lvaluehelper is added generally to theclassical.exprmodule because it's generally useful, whiletypes.cast_kindis moved from being a private method inexprto a public-API function soStorecan use it. These now come with associated unit tests.Details and comments
Depends on #10944.
Close #10939.
Release note to be added when closing #10922.