Revert "Relax CI constraint on numpy<1.25 (#11020)"
#11232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the restriction on the numpy version has introduced some non-determinism to some of the unitary synthesis tests that is causing a flaky failure in CI. This commit reverts the version cap removal to unblock CI. In parallel we should debug the source of the instability causing the test to fail so we can run CI using the latest version of numpy. This reverts commit fb8a69d.
mtreinish
added
type: qa
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6830264563
💛 - Coveralls |
jakelishman
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing the restriction on the numpy version has introduced some non-determinism to some of the unitary synthesis tests that is causing a flaky failure in CI. This commit reverts the version cap removal to unblock CI. In parallel we should debug the source of the instability causing the test to fail so we can run CI using the latest version of numpy.
Details and comments
This reverts commit fb8a69d.