-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transpiler mypy errors #11468
base: main
Are you sure you want to change the base?
Fix transpiler mypy errors #11468
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
369cddf
to
6a2329b
Compare
Pull Request Test Coverage Report for Build 9887903578Details
💛 - Coveralls |
|
||
from typing import Callable | ||
from collections.abc import Callable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a necessary change or just to normalize all the import Callable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using imports from typing
is deprecated
from functools import wraps | ||
from typing import Union, List, Any, TypeVar | ||
from typing import Any, List, Union, TypeVar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary change?
@@ -1095,7 +1095,7 @@ def physical_qubits(self): | |||
"""Returns a sorted list of physical_qubits""" | |||
return list(range(self.num_qubits)) | |||
|
|||
def get_non_global_operation_names(self, strict_direction=False): | |||
def get_non_global_operation_names(self, strict_direction: bool = False) -> list[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is bool =
necessary?
Summary
Fixing mypy errors for transpiler module. Followup to #8266
See also #6905
Details and comments
diff of mypy output before and after PR
Note that some errors appeared due to added types mypy couldn't derive previously.