Removal of _index and _registers from Bit
#11596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7700646687
💛 - Coveralls |
sbrandhsn
changed the title
|
One or more of the the following people are requested to review this:
|
sbrandhsn
changed the title
_index and _registers from Bit
1ucian0
reviewed
Jan 30, 2024
Comment on lines
+234
to
+239
| # and all( | ||
| # # For new-style bits, check bitwise equality. | ||
| # sbit == obit | ||
| # for sbit, obit in zip(self, other) | ||
| # if None in (sbit._register, sbit._index, obit._register, obit._index) | ||
| # ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses and builds on top of #11407
Details and comments
With the removal of
_indexand_registersfromBit,Bits become opaque and can only be distinguished by theirid. This breaks several test cases, requires a new de/serialization and a caching ofControlledGate.definition. These issues are addressed in this PR, leaving a potential refactoring ofLayoutfor the future (see #11604).