Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CXCancellation (and replacing it with InverseCancellation) #11937

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Deprecate CXCancellation (and replacing it with InverseCancellation) #11937

merged 1 commit into from
Mar 4, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Mar 2, 2024

Fixes #11212

Deprecating CXCancellation for 1.1

@1ucian0 1ucian0 requested a review from a team as a code owner March 2, 2024 18:47
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8124743591

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 89.318%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 4 91.94%
Totals Coverage Status
Change from base Build 8117135103: 0.05%
Covered Lines: 59139
Relevant Lines: 66212
💛 - Coveralls

@1ucian0 1ucian0 changed the title Deprecate CXCancellation (and replacing it with InverseCancellation Deprecate CXCancellation (and replacing it with InverseCancellation) Mar 3, 2024
@1ucian0 1ucian0 added this to the 1.1.0 milestone Mar 3, 2024
mtreinish
mtreinish approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up on that issue and deprecating the pass.

@mtreinish mtreinish added this pull request to the merge queue Mar 4, 2024
Merged via the queue into Qiskit:main with commit 4fd7faf Mar 4, 2024
12 checks passed
IsmaelCesar pushed a commit to comp-quantica/qiskit-terra that referenced this pull request Mar 13, 2024
@1ucian0 @IsmaelCesar
replace CXCancellation with InverseCancellation (Qiskit#11937)
b9a7229
@sbrandhsn sbrandhsn added Changelog: Bugfix Include in the "Fixed" section of the changelog Changelog: Deprecation Include in "Deprecated" section of changelog and removed Changelog: Bugfix Include in the "Fixed" section of the changelog labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Deprecate CXCancellation after 1.0 release
5 participants
@1ucian0 @qiskit-bot @coveralls @mtreinish @sbrandhsn