Install qiskit in ci env #1201
Closed
Install qiskit in ci env #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
mtreinish
force-pushed
the
install-qiskit-travis
branch
from
0fbb947
to
9ebdb70
Compare
|
Hmm the jupyter test failed: https://travis-ci.org/Qiskit/qiskit-terra/jobs/450005312#L1566 I think we need to modify that test to log the output to stdout/stderr on failure. |
|
Labelling as |
This commit ensures that we're actually installing qiskit in the travis environment. Previously we were just running tests out of the qiskit repo without installing it. This made things like testing jupyter or external commands more difficult because we had to properly setup the path to make sure the qiskit code was discoverable. This fixes that by installing qiskit (in develop mode) so that the code is linked to the python site-packages and is discoverable/importable by other python packages on the system, regardless of where they're run from. This is just a stopgap patch until we switch to using tox for ci, which will do this for us as well.
mtreinish
force-pushed
the
install-qiskit-travis
branch
from
08091b3
to
e1e03f2
Compare
|
This has been superseded by #1238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit ensures that we're actually installing qiskit in the travis
environment. Previously we were just running tests out of the qiskit
repo without installing it. This made things like testing jupyter or
external commands more difficult because we had to properly setup the
path to make sure the qiskit code was discoverable. This fixes that by
installing qiskit (in develop mode) so that the code is linked to the
python site-packages and is discoverable/importable by other python
packages on the system, regardless of where they're run from. This is
just a stopgap patch until we switch to using tox for ci, which will do
this for us as well.
Details and comments