Updates for removing use-maxsplit-arg

[joesho112358]

Summary

Part of the effort in #9614 to incrementally remove lints

Details and comments

Only used in one place. It makes sense if the line only cares about the extension. On the other hand, is also very much a nit in this case since most image files don't have multiple . in them and makes the line a bit longer.

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @enavarro51
• @Qiskit/terra-core

[coveralls]

Pull Request Test Coverage Report for Build 8731790615

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 10 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.009%) to 89.26%

---

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	4	91.35%
crates/qasm2/src/parse.rs	6	97.61%

Totals
Change from base Build 8728514558:	-0.009%
Covered Lines:	60305
Relevant Lines:	67561

---

💛 - Coveralls

[jakelishman]

This one also looks good, thanks.

Fwiw, I think there's a few in the "temporarily disabled" list that might not necessarily be the best style and might want moving into the "properly disabled" list, but it's been a long time since I looked at them, so I don't really remember. For example, the one above this one (use-implicit-booleaness-not-comparison) is imo not a universally good idea and probably shouldn't be enabled as a lint requirement.

[joesho112358]

This one also looks good, thanks.

Fwiw, I think there's a few in the "temporarily disabled" list that might not necessarily be the best style and might want moving into the "properly disabled" list, but it's been a long time since I looked at them, so I don't really remember. For example, the one above this one (use-implicit-booleaness-not-comparison) is imo not a universally good idea and probably shouldn't be enabled as a lint requirement.

Yeah, figured these were pretty quick hitters... so might as well go ahead and just do it! No biggie to throw the branch away and go the other route! :D

I can take a look at use-implicit-booleaness-not-comparison