Restrict iteration of commutation passes to just qubits #12318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CommutativeCancellation and CommutationAnalysis passes were previously iterating over the full set of wires in the DAGCircuit. However the wire list contains classical bits and also classical variables after Qiskit#12204 merges. The only thing these passes are concerned about are computing whether quantum operations commute and therefore don't need to work with any classical components in the DAG. In general these exta iterations were just no-ops because there wouldn't be anything evaluated on the wires, but doing this will avoid any potential overhead and limiting the search space to just where there is potential work to do.
mtreinish
added
performance
Changelog: None
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8909094749Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jakelishman
approved these changes
May 1, 2024
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
May 31, 2024
The CommutativeCancellation and CommutationAnalysis passes were previously iterating over the full set of wires in the DAGCircuit. However the wire list contains classical bits and also classical variables after Qiskit#12204 merges. The only thing these passes are concerned about are computing whether quantum operations commute and therefore don't need to work with any classical components in the DAG. In general these exta iterations were just no-ops because there wouldn't be anything evaluated on the wires, but doing this will avoid any potential overhead and limiting the search space to just where there is potential work to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CommutativeCancellation and CommutationAnalysis passes were previously iterating over the full set of wires in the DAGCircuit. However the wire list contains classical bits and also classical variables after #12204 merges. The only thing these passes are concerned about are computing whether quantum operations commute and therefore don't need to work with any classical components in the DAG. In general these exta iterations were just no-ops because there wouldn't be anything evaluated on the wires, but doing this will avoid any potential overhead and limiting the search space to just where there is potential work to do.
Details and comments