Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes for manual Var and Store #12421

Merged
merged 6 commits into from
May 16, 2024
Merged

Add release notes for manual Var and Store #12421

merged 6 commits into from
May 16, 2024

Conversation

jakelishman
Copy link
Member

Summary

This adds the release notes and updates some small portions of documentation that were previously missed surrounding the new manual Var storage locations.

This includes documenting all new keyword arguments to methods, upgrade instructions for providers, and adding the Var.new method to the documentation, which was previously erroneously omitted.

Details and comments

giphy

@jakelishman
Add release notes for manual Var and Store
38822bf 
This adds the release notes and updates some small portions of
documentation that were previously missed surrounding the new manual
`Var` storage locations.

This includes documenting all new keyword arguments to methods, upgrade
instructions for providers, and adding the `Var.new` method to the
documentation, which was previously erroneously omitted.
@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: New Feature Include in the "Added" section of the changelog Changelog: API Change Include in the "Changed" section of the changelog labels May 16, 2024
@jakelishman jakelishman added this to the 1.1.0 milestone May 16, 2024
@jakelishman jakelishman requested review from jyu00 and a team as code owners May 16, 2024 16:04
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

mtreinish
mtreinish reviewed May 16, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this new release note supersede: https://github.com/Qiskit/qiskit/blob/main/releasenotes/notes/1.1/classical-store-e64ee1286219a862.yaml

releasenotes/notes/storage-var-a00a33fcf9a71f3f.yaml Outdated Show resolved Hide resolved
@jakelishman
Copy link
Member Author

I'd forgotten I'd written that other release note, thanks. I've unified that first part in 144ade1.

@jakelishman jakelishman removed the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 16, 2024
@jakelishman
Copy link
Member Author

I've also removed the "stable backport" tag from this one - we can just cherry-pick the commit into #12371.

@jakelishman @mtreinish
Reword providers upgrade note
210f49f 
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
mtreinish approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as for the labels should this PR be Changelog: None as the actual feature PRs should have the labels right?

@mtreinish mtreinish enabled auto-merge May 16, 2024 16:28
@jakelishman jakelishman added Changelog: None Do not include in changelog and removed Changelog: New Feature Include in the "Added" section of the changelog Changelog: API Change Include in the "Changed" section of the changelog labels May 16, 2024
@jakelishman
Copy link
Member Author

Sure, I couldn't remember which we usually did.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9115797049

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.621%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.37%
Totals Coverage Status
Change from base Build 9113940979: 0.02%
Covered Lines: 62306
Relevant Lines: 69522
💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue May 16, 2024
Merged via the queue into Qiskit:main with commit 554e661 May 16, 2024
15 checks passed
mtreinish pushed a commit to sbrandhsn/qiskit that referenced this pull request May 16, 2024
@jakelishman @mtreinish
Add release notes for manual Var and Store (Qiskit#12421)
6199cc5 
* Add release notes for manual `Var` and `Store`

This adds the release notes and updates some small portions of
documentation that were previously missed surrounding the new manual
`Var` storage locations.

This includes documenting all new keyword arguments to methods, upgrade
instructions for providers, and adding the `Var.new` method to the
documentation, which was previously erroneously omitted.

* Fix Sphinx typo

* Fix another Sphinx typo

* Move QPY version bump to upgrade

* Unify base release note

* Reword providers upgrade note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit 554e661)
@jakelishman jakelishman deleted the doc/var-updates branch May 16, 2024 18:22
mtreinish added a commit that referenced this pull request May 16, 2024
@sbrandhsn @mtreinish
@ihincks @1ucian0 @jakelishman
Prepare 1.1.0 release (#12371)
7d29dc1 
This commit prepares the repo for the 1.1.0 release. It updates the version numbers to indicate it is the final 1.1.0 release, and updates the release notes to prepare them for publishing. Once this merges this commit should be used to tag the 1.1.0 release.

* draft 1.1.0

* fixes text/typos

* .

* .

* Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Ian Hincks <ian.hincks@gmail.com>

* up

* up

* Update releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/star-prerouting-0998b59880c20cef.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* prelude - add platform support

* prelude update

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/added-parameter-ctrl_state-mcx-816dcd80e459a5ed.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/add-annotated-arg-to-power-4afe90e89fa50f5a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/add-ctrl_state-mcp-parameter-b23562aa7047665a.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* comments from code review

* Apply suggestions from code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/abstract-commutation-analysis-3518129e91a33599.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update qiskit/primitives/containers/shape.py

Co-authored-by: Ian Hincks <ian.hincks@gmail.com>

* Update shape.py

* Apply suggestions from code review

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/1.1/prepare-1.1.0-732e167b70ab4d01.yaml

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

* .

* .

* Move and update new fix release notes

* Small tweaks

* Remove fix note for private API

* Add release notes for manual `Var` and `Store` (#12421)

* Add release notes for manual `Var` and `Store`

This adds the release notes and updates some small portions of
documentation that were previously missed surrounding the new manual
`Var` storage locations.

This includes documenting all new keyword arguments to methods, upgrade
instructions for providers, and adding the `Var.new` method to the
documentation, which was previously erroneously omitted.

* Fix Sphinx typo

* Fix another Sphinx typo

* Move QPY version bump to upgrade

* Unify base release note

* Reword providers upgrade note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit 554e661)

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request May 31, 2024
@jakelishman @mtreinish @ElePT
Add release notes for manual Var and Store (Qiskit#12421)
06650e2 
* Add release notes for manual `Var` and `Store`

This adds the release notes and updates some small portions of
documentation that were previously missed surrounding the new manual
`Var` storage locations.

This includes documenting all new keyword arguments to methods, upgrade
instructions for providers, and adding the `Var.new` method to the
documentation, which was previously erroneously omitted.

* Fix Sphinx typo

* Fix another Sphinx typo

* Move QPY version bump to upgrade

* Unify base release note

* Reword providers upgrade note

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
1.1.0
4 participants
@jakelishman @qiskit-bot @coveralls @mtreinish