Check for gate parameter #12439
Check for gate parameter #12439
Conversation
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9136334258Details
💛 - Coveralls |
| @@ -95,4 +95,4 @@ def get_calibration(self, node_op: CircuitInst, qubits: List) -> Union[Schedule, | |||
| Raises: | |||
| TranspilerError: When node is parameterized and calibration is raw schedule object. | |||
| """ | |||
| return self.target.get_calibration(node_op.name, tuple(qubits), *node_op.params) | |||
| return self.target.get_calibration(node_op.name, tuple(qubits), None, *node_op.params) | |||
There was a problem hiding this comment.
Reviewer's comment anticipated! :)
I am not super satisfied with putting None here.
Here, the parameter node_op.params has the actual list of float parameters to bind with the Gate's parameters stored in the target which is a parameter(variable). That is why I had to put None just to keep the function's behavior similar to its previous version.
| ) | ||
|
|
||
| def test_get_calibration_for_oper_with_param_pulse_with_param(self): | ||
| args = {0.23, 0.123, 0.2} |
There was a problem hiding this comment.
Considering theta maps to amp, sigma, and, beta. The emphasis here is just to prove that multiple *args could be successfully bind if equal number of parameter(variable) present in the actual Schedule
Summary
This PR aims to fix an issue with
Target.has_calibration()andTarget.get_calibration()when passed with parameterized gates didn't work as expected.Refer to issues for more information.
#11658
#11657
Details and comments
To be precise,
Target.has_calibration()didn't check if the calibration if present is present for a particular gate with a particular parameter,and,
Target.get_calibration()didn't get the calibration for the gate if present is present for a particular gate with a particular parameter, when passed as a parameter asargs, the method tried to bind thisargswith a parameter in the schedule, which was not the intention of this particularargs.So, the signature of
Target.has_calibrationincludes a new argumentoperation_paramswhich has to be passed with the parameter of theGateif the Gate is parameterized.Similarly, the signature of
Target.get_calibrationalso includes a new argumentoperation_paramswhich has to be passed with the parameter of theGateif the Gate is parameterized. In the case ofargsargument in this function, it should be passed with the values to be bound with the parameter of the schedule which has been attached to this particular gate as its calibration.fixes #11658
fixes #11657