Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameters property to BindingsArray #12461

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shraddha-aangiras
Copy link
Contributor

Summary

Fixes #12436

Details and comments

@shraddha-aangiras shraddha-aangiras requested review from a team as code owners May 26, 2024 16:21
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label May 26, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @t-imamichi

@CLAassistant
Copy link

CLAassistant commented May 26, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9834778482

Details

  • 2 of 7 (28.57%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.816%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/primitives/containers/bindings_array.py 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.88%
crates/qasm2/src/parse.rs 12 96.23%
Totals Coverage Status
Change from base Build 9825985118: -0.02%
Covered Lines: 65204
Relevant Lines: 72597

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add parameters property to BindingsArray
4 participants