Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated U3 gate in random hex benchmarks #12514

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Procatv
Copy link
Contributor

@Procatv Procatv commented Jun 5, 2024

Summary

Changed in the code qc.U3 to qc.U as the U3Gate is deprecated

Details and comments

Per the U3Gate documentation: https://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.library.U3Gate this gate is deprecated and instead should be replaced by theqc.U

Fixes #12503

@Procatv Procatv requested a review from a team as a code owner June 5, 2024 20:16
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 5, 2024
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2024

CLA assistant check
All committers have signed the CLA.

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9390663159

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 89.585%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 6 91.86%
Totals Coverage Status
Change from base Build 9372719342: -0.003%
Covered Lines: 62364
Relevant Lines: 69614

💛 - Coveralls

@raynelfss raynelfss added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog Intern PR PR submitted by IBM Quantum interns and removed Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Jun 6, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtreinish mtreinish added this pull request to the merge queue Jun 6, 2024
@mtreinish mtreinish changed the title depreciated U3 gate (qc.U3) changed to qc.U Stop using deprecated U3 gate (qc.U3) changed to qc.U in random hex benchmarks Jun 6, 2024
@mtreinish mtreinish changed the title Stop using deprecated U3 gate (qc.U3) changed to qc.U in random hex benchmarks Stop using deprecated U3 gate in random hex benchmarks Jun 6, 2024
@jakelishman jakelishman removed this pull request from the merge queue due to a manual request Jun 6, 2024
@jakelishman jakelishman added this pull request to the merge queue Jun 6, 2024
Merged via the queue into Qiskit:main with commit 90f09da Jun 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Intern PR PR submitted by IBM Quantum interns type: qa Issues and PRs that relate to testing and code quality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Depreciation error for gate u3 in random_circuit_hex
7 participants