Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed not-context-manager and ordered lint rules #12607

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joesho112358
Copy link
Contributor

Summary

This should close out #9614

Details and comments

Removes not-context-manager and orders lint rules alphabetically

@joesho112358 joesho112358 requested a review from a team as a code owner June 19, 2024 18:19
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 19, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9586581711

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.746%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 92.62%
crates/qasm2/src/parse.rs 6 96.69%
Totals Coverage Status
Change from base Build 9585515412: -0.01%
Covered Lines: 63560
Relevant Lines: 70822

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9607055660

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 89.74%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.37%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 9602245093: 0.0%
Covered Lines: 63573
Relevant Lines: 70841

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9706332095

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 89.746%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.11%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 9703107599: 0.006%
Covered Lines: 63802
Relevant Lines: 71092

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants