Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: README.md: Jupyter notebooks are #176

Merged
merged 2 commits into from Dec 6, 2017
Merged

Conversation

westurner
Copy link
Contributor

@westurner westurner commented Dec 6, 2017

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • DOC: Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@westurner westurner mentioned this pull request Dec 6, 2017
Copy link
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @westurner! However, the paragraph you are modifying refers to Jupyter (the software) rather than the individual notebooks themselves - could you please revise the change, leaving the is and replacing Notebooks with Notebook? Ie.

... [Jupyter Notebook](https://jupyter.readthedocs.io/en/latest/install.html) is ...

@westurner
Copy link
Contributor Author

westurner commented Dec 6, 2017

I've revised the change.

Jupyter Notebook is the software application for working with Jupyter notebooks (.ipnb's, 'notebook documents')

@diego-plan9
Copy link
Member

Thanks for catching it and for the adjustment - merging!

@diego-plan9 diego-plan9 merged commit d2e9c2d into Qiskit:master Dec 6, 2017
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* DOC: README.md: Jupyter notebooks are

* DOC: README.md: Jupyter Notebook is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants