Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Fix multiple appends of '_dg' in name attribute on calling inverse() #6563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e82f04
Fix multiple appends of '_dg' in name attribute.
jwalaQ Jun 11, 2021
1f94d76
Add tests and release notes.
jwalaQ Jun 11, 2021
8e27720
Update bugfix-gate-inverse-name-3401093a18813ace.yaml
jwalaQ Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions qiskit/circuit/instruction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,18 +337,20 @@ def inverse(self):

from qiskit.circuit import QuantumCircuit, Gate # pylint: disable=cyclic-import

if self.name.endswith("_dg"):
name = self.name[:-3]
else:
name = self.name + "_dg"
if self.num_clbits:
inverse_gate = Instruction(
name=self.name + "_dg",
name=name,
num_qubits=self.num_qubits,
num_clbits=self.num_clbits,
params=self.params.copy(),
)

else:
inverse_gate = Gate(
name=self.name + "_dg", num_qubits=self.num_qubits, params=self.params.copy()
)
inverse_gate = Gate(name=name, num_qubits=self.num_qubits, params=self.params.copy())

inverse_gate.definition = QuantumCircuit(
*self.definition.qregs,
Expand Down
8 changes: 8 additions & 0 deletions releasenotes/notes/bugfix-gate-inverse-name-3401093a18813ace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
fixes:
- |
Fixed bug in assigning name attribute to ``inverse()`` function of
:class:`~qiskit.circuit.Gate` (inherited from :class:`~qiskit.circuit.Instruction`).
Earlier, the inverse() function returned a gate with label None. Now
the label of inverse is built using the label calling it.
`#6563 <https://github.com/Qiskit/qiskit-terra/pull/6563>` for more details.
11 changes: 11 additions & 0 deletions test/python/circuit/test_instructions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,17 @@ def test_inverse_with_global_phase(self):
gate_inverse = circ.to_instruction()
self.assertEqual(gate.inverse().definition, gate_inverse.definition)

def test_inverse_with_label(self):
"""test inverting gate initialized with label attribute."""
q = QuantumRegister(2)
qc = QuantumCircuit(q, name="circ")
qc.cx(0, 1)
qc_gate = qc.to_gate()
qc_gate_inverse = qc_gate.inverse()
self.assertEqual(qc_gate.name + "_dg", qc_gate_inverse.name)
qc_gate_inverse_inverse = qc_gate_inverse.inverse()
self.assertEqual(qc_gate_inverse_inverse.name, qc_gate.name)

def test_no_broadcast(self):
"""See https://github.com/Qiskit/qiskit-terra/issues/2777
When creating custom instructions, do not broadcast parameters"""
Expand Down