scipy minimal required version does not have unitary_group

[diego-plan9]

Informations

The changes included in #760 require a scipy version that provides scipy.stats.unitary_group, which is not available in the minimal version currently required for scipy:

scipy>=0.19

We should look for the minimal version of scipy that includes that function (seems to be 1.0) and update the dependencies accordingly - otherwise we risk installations with broken qiskit.tools.qi.qi in some cases.

[jaygambetta]

@diego-plan9 can you just update the dependencies as we don't want to write this function.

[delapuente]

This is on its way to be fixed via #713

[dtmcclure]

@diego-plan9 @delapuente this issue still has not been fixed: requirements.txt still lists scipy>=0.19, and qiskit.tools.qi.qi still tries to import unitary_group from scipy.stats

[diego-plan9]

Thanks for reporting, @dtmcclure - can you paste the version of scipy you have installed that is resulting in a problem?

I'm reopening the issue so we can investigate further - and actually pinging @ewinston as he might have more information. Based on https://github.com/Qiskit/qiskit-terra/pull/713/files#r214942849:

For some reason scipy 0.19.1 doesn't implement unitary_group although it does before (0.19.0) and after (1.0).

But it could be the case that the exclusion of 0.19.1 might not be enough.

[ewinston]

I thought this was in 0.19.0 but I couldn't find it. Maybe just change requirement to >=1.0.0 or maybe Jay has other idea?

[dtmcclure]

Diego yeah I was using 0.19.0 and it could not find unitary_group. This is consistent with the scipy source code: Not present in 0.19.0: https://github.com/scipy/scipy/blob/v0.19.0/scipy/stats/_multivariate.py Present in 1.0.0: https://github.com/scipy/scipy/blob/v1.0.0/scipy/stats/_multivariate.py

…

On Mon, Feb 4, 2019 at 3:50 PM ewinston ***@***.***> wrote: I thought this was in 0.19.0 but I couldn't find it. Maybe just change requirement to >=1.0.0? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#829 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AanFzfKlSw3IWtd-09cjO2y00lJ75OtDks5vKJ0lgaJpZM4WPRGd> .

[jaygambetta]

@dtmcclure can you check now

[dtmcclure]

Looking at the changes proposed in the PR, it appears they will fix the problem once approved.

…

On Sun, Feb 24, 2019 at 3:29 PM Jay Gambetta ***@***.***> wrote: @dtmcclure <https://github.com/dtmcclure> can you check now — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#829 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AanFzT_7wtcjIz0DkWLtV7BCVIqKSqmoks5vQvYngaJpZM4WPRGd> .