Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-complex dtypes in OneQubitEulerDecomposer methods #9828

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Fix non-complex dtypes in OneQubitEulerDecomposer methods #9828

merged 3 commits into from
Mar 20, 2023

Commits on Mar 20, 2023

  1. Fix non-complex dtypes in OneQubitEulerDecomposer methods 

    This commit fixes a regression introduced in the rewrite of the
internals of the OneQubitEulerDecomposer class to be in rust. Previously
the angles() and angles_and_phase() methods of OneQubitEulerDecomposer
would work with a non-complex dtype in the input, however because the
rust component of the module is strictly typed to only work with a
complex128 dtype passing the array to rust to compute the angles and
phase of the unitary would fail. To address this limitation this commit
casts the input matrix to be complex before passing it to the rust
function.

Fixes Qiskit#9827
    @mtreinish
    mtreinish committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    3e8b19e View commit details
    Browse the repository at this point in the history

  2. Cleanup release note

    @mtreinish
    mtreinish committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    448470a View commit details
    Browse the repository at this point in the history

  3. Update test/python/quantum_info/test_synthesis.py 

    Co-authored-by: Jake Lishman <jake@binhbar.com>
    @mtreinish @jakelishman
    mtreinish and jakelishman committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7f64aa5 View commit details
    Browse the repository at this point in the history